Differences between revisions 6 and 7
Revision 6 as of 2008-06-09 15:31:36
Size: 1631
Editor: FelixFrank
Comment: opened section of unidentified patch parts
Revision 7 as of 2008-06-09 16:43:20
Size: 2095
Editor: FelixFrank
Comment: more mystery
Deletions are marked like this. Additions are marked like this.
Line 26: Line 26:
 * {o} src/viced/afsfileprocs.c:229
  * this function is declared here in Hartmuts code. not yet sure why. probably because of the use introduced into common_StoreData64. not yet sure what kind of fixes are hidden here and to what extent they're required. '''Watch patches for calls to `common_StoreData64`'''!

 * {o} src/viced/afsfileprocs.c:3715
  * as mentioned above, the function common_StoreData64 was patched quite a bit. might have to ask Hartmut.

TableOfContents

SVN test repository

(!) Original openafs-1.4.7 sources were checked into revision 2.

The URL is file://localhost/afs/ifh.de/user/f/ffrank/osd_svn. ACLs currently allow user ffrank only.

Creating the patch

{{{ cd trunk/openafs-1.4.7 svn diff -r 2:HEAD -x -b >| ../full-patch }}} The -x -b option (hopefully) causes svn to ignore changes in amount of whitespace (like diff -b).

iokaste crash recovery 2008-04-17

  • syslog unconclusive
  • AFS logs held no hints, either
    • update 2008-05-26: the problems with fs replaceosd were likely related to version mismatches between io and iokaste (fs != rxosd)

patch analysis

unidentified snippets

  • {o} src/viced/afsfileprocs.c:2472

    • Hartmut inserted an #ifdef AFS_NT40_ENV protecting two functions and some definitions. Probably a fix.

  • {o} src/viced/afsfileprocs.c:229

    • this function is declared here in Hartmuts code. not yet sure why. probably because of the use introduced into common_StoreData64. not yet sure what kind of fixes are hidden here and to what extent they're required. Watch patches for calls to common_StoreData64!

  • {o} src/viced/afsfileprocs.c:3715

    • as mentioned above, the function common_StoreData64 was patched quite a bit. might have to ask Hartmut.

isolating vos splitvol

  • sought through the patch, identifying places where
    • the client command was changed
    • the server was given the extra RPC
  • used vimdiff to introduce changes into

    • rxgen file
    • vos implementation
    • volser implementation

    and added the new vol_split.c code file, therefore

    • also updating volser's Makefile.in

  • Conclusion

    It turns out that the volsplit functionality depends on the reverse lookup functionality, also new with the full patch. Thus isolating volsplit failed at this stage and must be postponed until reverse lookups have been isolated.

    Addendum

    Apparently, InverseLookup is only used by vos splitvol, so both possibly belong in the same sub patch. For better

AfsOsd/Logs (last edited 2009-02-16 11:05:51 by FelixFrank)