1964
Comment: attached first batch of patches
|
2256
update of initial patchset
|
Deletions are marked like this. | Additions are marked like this. |
Line 14: | Line 14: |
1. Protocol Abstraction Layer: [[attachment:protocol-abstraction-2009-07-01.mb]] | /!\ Notice that updates are most likely rebased, so you should `reset --hard` to the original pristine state and reapply the whole thing. 1. Protocol Abstraction Layer: [[attachment:protocol-abstraction-2009-07-01.mb]] (''obsolete'') * UPDATE: followed up on Simon's suggestions: [[attachment:protocol-abstraction-2009-07-02.mb]] |
Line 25: | Line 28: |
The caches should use identical Fetch/Store routines. This patch concerns only Store. The code is quite insane, as this patch is only a bridge to rxosd-03. | The caches should use identical Fetch/Store routines. This patch concerns only Store. |
Line 27: | Line 30: |
== rxosd-03 == The actual protocol abstraction. !StoreOps are yet another differentiation layer underneath cache type abstraction. Interaction with `rxosd` servers will manifest itself in form of a set of alternative !StoreOps. |
!StoreOps are yet another differentiation layer underneath cache type abstraction. Interaction with `rxosd` servers will manifest itself in form of a set of alternative !StoreOps. |
Line 32: | Line 34: |
== rxosd-04 == | == rxosd-03 == |
Line 35: | Line 37: |
== rxosd-05 and rxosd-06 == These are the counterparts of rxosd-02 and rxosd-03 wrt. the `CacheFetchProc`s. |
== rxosd-04 == The counterparts of rxosd-02 wrt. the `CacheFetchProc`s. == rxosd-05 == Another simplification - this comes for free, as without the macros from ''afs_chunkops.h'', the pointers from afs_cacheOps were no longer used for !StoreProc / !FetchProc. |
Contents
About the patches
For (my) convenience, I opted to store the patches in form of a mailbox as generated by
git format-patch --stdout
Ideally, you use a git repository and
git checkout -b rxosd-patches openafs-stable-1_4_10 git am <patch-file.mb
You then have all the goodness of git to review the changes.
Alternatively, it shouldn't be too hard to retrieve individual u-diffs from the files.
Latest patches
Notice that updates are most likely rebased, so you should reset --hard to the original pristine state and reapply the whole thing.
Protocol Abstraction Layer: protocol-abstraction-2009-07-01.mb (obsolete)
UPDATE: followed up on Simon's suggestions: protocol-abstraction-2009-07-02.mb
Overview
Client changes
- Protocol Abstraction Layer
Unifies CacheStoreProc / CacheFetchProc routines for UFS- and MemCache, respectively. Encapsules server interactions into discrete functions that are specific to the cache type used. Additional protocols can be added relatively easy then, by defining additional sets of Store/Fetch mini-operations.
Protocol Abstraction layer
rxosd-01
The CacheStoreProcs and CacheStoreProcs for the respective cache types are counterintuitively distributed in the source tree. We propose a new afs_fetchstore.c for these.
rxosd-02
The caches should use identical Fetch/Store routines. This patch concerns only Store.
StoreOps are yet another differentiation layer underneath cache type abstraction. Interaction with rxosd servers will manifest itself in form of a set of alternative StoreOps.
Note that the ((struct rxfs_storeVariables *)rock)->call = acall; line is actually a hack. The final rxfs_storeInit() will work rather differently than how it does now, so this is my way of bridging the gap.
rxosd-03
Make code more readable, and replace some return codes.
rxosd-04
The counterparts of rxosd-02 wrt. the CacheFetchProcs.
rxosd-05
Another simplification - this comes for free, as without the macros from afs_chunkops.h, the pointers from afs_cacheOps were no longer used for StoreProc / FetchProc.